Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Added better logging on startup, make sure we kill server if healthcheck fails, wait longer#306

Merged
jhaynie merged 1 commit intomainfrom
more-startup
May 18, 2025
Merged

Added better logging on startup, make sure we kill server if healthcheck fails, wait longer#306
jhaynie merged 1 commit intomainfrom
more-startup

Conversation

@jhaynie
Copy link
Copy Markdown
Member

@jhaynie jhaynie commented May 18, 2025 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Improvements
    • Enhanced logging during the project server startup process, providing more detailed trace messages and process information.
    • Increased the health check retry duration for the server, allowing up to 30 seconds for successful startup.
    • Improved trace output for health check attempts, including attempt count and elapsed time.
    • Ensured the server process is properly terminated if the health check fails.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2025 •
edited
Loading

Walkthrough

The changes introduce enhanced trace-level logging and process management for starting the project server, including logging before and after server startup and improved cleanup on health check failure. Additionally, the health check retry duration is increased, and logging within the health check loop is made more detailed.

Changes

File(s) Change Summary
cmd/dev.go Added trace logs before and after starting the project server, including process ID. Ensured server process is killed if health check fails before closing the UI.
internal/dev/server.go Extended health check retry duration from 15 to 30 seconds. Improved trace logging to include attempt count and elapsed time.

Sequence Diagram(s)

sequenceDiagram
    participant DevCommand
    participant ProjectServer
    participant HealthCheck

    DevCommand->>DevCommand: Log "Starting project server"
    DevCommand->>ProjectServer: Start process
    DevCommand->>DevCommand: Log "Project server started (PID)"
    DevCommand->>HealthCheck: Begin health check (retry up to 30s)
    loop Health Check Attempts
        HealthCheck->>ProjectServer: Send health check request
        HealthCheck->>DevCommand: Log attempt count and elapsed time
        alt Health check fails and timeout reached
            DevCommand->>ProjectServer: Kill process
            DevCommand->>DevCommand: Close UI and return
        end
    end
Loading

Poem

A rabbit logs with nimble paws,
Before the server wakes or snores.
If health checks fail, cleanup’s neat—
The process ends, no messy feat.
With longer waits and traces clear,
The code now hops with less to fear!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 05b75ee and 3b89aeb.

📒 Files selected for processing (2)
  • cmd/dev.go (1 hunks)
  • internal/dev/server.go (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
cmd/dev.go (3)
internal/errsystem/errsystem.go (2)
  • New (33-63)
  • WithContextMessage (100-104)
internal/errsystem/errorcodes.go (1)
  • ErrInvalidConfiguration (25-28)
internal/dev/dev.go (1)
  • KillProjectServer (18-56)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Build and Test (windows-latest)
  • GitHub Check: Test CLI Upgrade Path (windows-latest)
  • GitHub Check: Analyze (go)
🔇 Additional comments (4)
internal/dev/server.go (1)

461-463: Improved health check reliability with extended timeout and better logging.

The health check duration has been doubled from 15 to 30 seconds, giving servers more time to initialize in slower environments. The enhanced trace logging now includes helpful diagnostic information (attempt count and elapsed time) for better debugging when issues occur.

cmd/dev.go (3)

210-210: Enhanced server lifecycle traceability with pre-start logging.

Adding trace logging before starting the project server improves observability of the server lifecycle, making it easier to debug startup issues.

216-216: Added post-start logging with process ID.

This trace log provides confirmation that the server process has started successfully and captures the process ID, which is valuable for monitoring and debugging.

220-220: Added explicit server cleanup on health check failure.

This important addition ensures that the project server process is properly terminated if the health check fails, preventing orphaned processes and potential resource leaks.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jhaynie jhaynie merged commit de1f0cc into main May 18, 2025
15 checks passed
@jhaynie jhaynie deleted the more-startup branch May 18, 2025 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jhaynie